Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output external clusterings with visualisations #307

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Conversation

nickjcroucher
Copy link
Collaborator

Some fixes to the code, and added a new test (test_beebop.py), although not sure if this is being run with the CI? Code not perfect but better.

@nickjcroucher nickjcroucher requested a review from johnlees March 12, 2024 15:55
@nickjcroucher
Copy link
Collaborator Author

@EmmaLRussell has confirmed this enables beebop to produce networks annotated with external clustering.

Copy link
Member

@johnlees johnlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need to bump the version again

PopPUNK/visualise.py Show resolved Hide resolved
PopPUNK/visualise.py Outdated Show resolved Hide resolved
test/test-beebop.py Outdated Show resolved Hide resolved
@nickjcroucher
Copy link
Collaborator Author

Version bumped in d5179fd, thank you for the quick review!

@nickjcroucher nickjcroucher merged commit 27982a5 into master Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants